🎨 Removed unused dependency injected services arguments in constructor

DysonNetwork.Sphere/Account/AccountController.cs

@@ -1,7 +1,6 @@
 using System.ComponentModel.DataAnnotations;
 using DysonNetwork.Sphere.Auth;
 using DysonNetwork.Sphere.Permission;
-using DysonNetwork.Sphere.Storage;
 using Microsoft.AspNetCore.Authorization;
 using Microsoft.AspNetCore.Mvc;
 using Microsoft.EntityFrameworkCore;
@@ -15,11 +14,9 @@ namespace DysonNetwork.Sphere.Account;
 [Route("/accounts")]
 public class AccountController(
     AppDatabase db,
-    FileService fs,
     AuthService auth,
     AccountService accounts,
-    AccountEventService events,
-    MagicSpellService spells
+    AccountEventService events
 ) : ControllerBase
 {
     [HttpGet("{name}")]

DysonNetwork.Sphere/Account/NotificationService.cs

@@ -10,7 +10,6 @@ namespace DysonNetwork.Sphere.Account;
 public class NotificationService(
     AppDatabase db,
     WebSocketService ws,
-    ILogger<NotificationService> logger,
     IHttpClientFactory httpFactory,
     IConfiguration config)
 {

DysonNetwork.Sphere/Auth/AuthService.cs

@@ -58,7 +58,7 @@ public class AuthService(AppDatabase db, IConfiguration config, IHttpClientFacto
 
         // 4) Combine base “maxSteps” (the number of enabled factors) with any accumulated risk score.
         const int totalRiskScore = 3;
-        var totalRequiredSteps = (int)Math.Round((float)maxSteps * riskScore / 3);
+        var totalRequiredSteps = (int)Math.Round((float)maxSteps * riskScore / totalRiskScore);
         // Clamp the steps
         totalRequiredSteps = Math.Max(Math.Min(totalRequiredSteps, maxSteps), 1);
 

DysonNetwork.Sphere/Auth/OpenId/ConnectionController.cs

@@ -304,7 +304,7 @@ public class ConnectionController(
         {
             await db.SaveChangesAsync();
         }
-        catch (DbUpdateException ex)
+        catch (DbUpdateException)
         {
             return StatusCode(500, $"Failed to save {provider} connection. Please try again.");
         }

DysonNetwork.Sphere/Auth/OpenId/DiscordOidcService.cs

@@ -33,15 +33,15 @@ public class DiscordOidcService(
         return $"https://discord.com/api/oauth2/authorize?{queryString}";
     }
     
-    protected override async Task<OidcDiscoveryDocument?> GetDiscoveryDocumentAsync()
+    protected override Task<OidcDiscoveryDocument?> GetDiscoveryDocumentAsync()
     {
-        return new OidcDiscoveryDocument
+        return Task.FromResult(new OidcDiscoveryDocument
         {
             AuthorizationEndpoint = "https://discord.com/oauth2/authorize",
             TokenEndpoint = "https://discord.com/api/oauth2/token",
             UserinfoEndpoint = "https://discord.com/api/users/@me",
             JwksUri = null
-        };
+        })!;
     }
     
     public override async Task<OidcUserInfo> ProcessCallbackAsync(OidcCallbackData callbackData)

DysonNetwork.Sphere/Chat/ChatRoomController.cs

@@ -16,7 +16,6 @@ namespace DysonNetwork.Sphere.Chat;
 [Route("/chat")]
 public class ChatRoomController(
     AppDatabase db,
-    FileService fs,
     FileReferenceService fileRefService,
     ChatRoomService crs,
     RealmService rs,

DysonNetwork.Sphere/Chat/ChatService.cs

@@ -9,7 +9,6 @@ namespace DysonNetwork.Sphere.Chat;
 
 public class ChatService(
     AppDatabase db,
-    FileService fs,
     FileReferenceService fileRefService,
     IServiceScopeFactory scopeFactory,
     IRealtimeService realtime,

DysonNetwork.Sphere/Publisher/PublisherController.cs

@@ -16,7 +16,6 @@ namespace DysonNetwork.Sphere.Publisher;
 public class PublisherController(
     AppDatabase db,
     PublisherService ps,
-    FileService fs,
     FileReferenceService fileRefService,
     ActionLogService als)
     : ControllerBase

DysonNetwork.Sphere/Publisher/PublisherService.cs

@@ -6,7 +6,7 @@ using NodaTime;
 
 namespace DysonNetwork.Sphere.Publisher;
 
-public class PublisherService(AppDatabase db, FileService fs, FileReferenceService fileRefService, ICacheService cache)
+public class PublisherService(AppDatabase db, FileReferenceService fileRefService, ICacheService cache)
 {
     private const string UserPublishersCacheKey = "accounts:{0}:publishers";
 

DysonNetwork.Sphere/Realm/RealmController.cs

@@ -13,7 +13,6 @@ namespace DysonNetwork.Sphere.Realm;
 public class RealmController(
     AppDatabase db,
     RealmService rs,
-    FileService fs,
     FileReferenceService fileRefService,
     RelationshipService rels,
     ActionLogService als

DysonNetwork.Sphere/Storage/CloudFileUnusedRecyclingJob.cs

@@ -6,7 +6,6 @@ namespace DysonNetwork.Sphere.Storage;
 
 public class CloudFileUnusedRecyclingJob(
     AppDatabase db,
-    FileService fs,
     FileReferenceService fileRefService,
     ILogger<CloudFileUnusedRecyclingJob> logger
 )

DysonNetwork.Sphere/Storage/Handlers/LastActiveFlushHandler.cs

@@ -6,8 +6,8 @@ namespace DysonNetwork.Sphere.Storage.Handlers;
 
 public class LastActiveInfo
 {
-    public Auth.Session Session { get; set; }
-    public Account.Account Account { get; set; }
+    public Auth.Session Session { get; set; } = null!;
+    public Account.Account Account { get; set; } = null!;
     public Instant SeenAt { get; set; }
 }