From 68399dd3718197b0c218a4fd20ba8fae92de6a68 Mon Sep 17 00:00:00 2001 From: LittleSheep Date: Sun, 25 May 2025 12:12:37 +0800 Subject: [PATCH] :bug: Fix post-reply will still create normal activities :bug: Fix publisher get by name endpoint requires authorization --- DysonNetwork.Sphere/Activity/ActivityService.cs | 7 +++++-- DysonNetwork.Sphere/Publisher/PublisherController.cs | 2 -- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/DysonNetwork.Sphere/Activity/ActivityService.cs b/DysonNetwork.Sphere/Activity/ActivityService.cs index 781be7f..47ef8e5 100644 --- a/DysonNetwork.Sphere/Activity/ActivityService.cs +++ b/DysonNetwork.Sphere/Activity/ActivityService.cs @@ -133,9 +133,11 @@ public class ActivityService(AppDatabase db) var identifier = $"posts/{post.Id}"; if (post.RepliedPostId is not null) { - var ogPost = await db.Posts.Where(e => e.Id == post.RepliedPostId).Include(e => e.Publisher) + var ogPost = await db.Posts + .Where(e => e.Id == post.RepliedPostId) + .Include(e => e.Publisher) .FirstOrDefaultAsync(); - if (ogPost == null) return; + if (ogPost?.Publisher.AccountId == null) return; await CreateActivity( user, "posts.new.replies", @@ -143,6 +145,7 @@ public class ActivityService(AppDatabase db) ActivityVisibility.Selected, [ogPost.Publisher.AccountId!.Value] ); + return; } await CreateActivity( diff --git a/DysonNetwork.Sphere/Publisher/PublisherController.cs b/DysonNetwork.Sphere/Publisher/PublisherController.cs index e809072..fc03697 100644 --- a/DysonNetwork.Sphere/Publisher/PublisherController.cs +++ b/DysonNetwork.Sphere/Publisher/PublisherController.cs @@ -19,8 +19,6 @@ public class PublisherController(AppDatabase db, PublisherService ps, FileServic [HttpGet("{name}")] public async Task> GetPublisher(string name) { - if (HttpContext.Items["CurrentUser"] is not Account.Account currentUser) return Unauthorized(); - var publisher = await db.Publishers .Where(e => e.Name == name) .FirstOrDefaultAsync();