From bdc277a2e34f1905307560d00c64e7be791d54dc Mon Sep 17 00:00:00 2001
From: LittleSheep <littlesheep.code@hotmail.com>
Date: Tue, 16 Dec 2025 23:54:33 +0800
Subject: [PATCH] :bug: Fix update app color fail sometimes

---
 lib/logic/audio_handler.dart      | 26 ++++++++++------------
 lib/logic/metadata_service.dart   |  1 -
 lib/providers/theme_provider.dart | 36 ++++++++++++-------------------
 3 files changed, 25 insertions(+), 38 deletions(-)

diff --git a/lib/logic/audio_handler.dart b/lib/logic/audio_handler.dart
index 5b4fa76..2368560 100644
--- a/lib/logic/audio_handler.dart
+++ b/lib/logic/audio_handler.dart
@@ -1,8 +1,9 @@
 import 'package:audio_service/audio_service.dart';
-import 'package:flutter_riverpod/flutter_riverpod.dart';
+import 'package:hooks_riverpod/hooks_riverpod.dart';
 import 'package:media_kit/media_kit.dart' as media_kit;
 import 'package:groovybox/data/db.dart';
 import 'package:groovybox/providers/theme_provider.dart';
+import 'package:groovybox/logic/metadata_service.dart';
 
 class AudioHandler extends BaseAudioHandler with QueueHandler, SeekHandler {
   final media_kit.Player _player;
@@ -46,23 +47,18 @@ class AudioHandler extends BaseAudioHandler with QueueHandler, SeekHandler {
   }
 
   // Update theme color based on current track's album art
-  void _updateThemeFromCurrentTrack(MediaItem mediaItem) {
+  void _updateThemeFromCurrentTrack(MediaItem mediaItem) async {
     if (_container == null) return;
 
-    final artUri = mediaItem.artUri;
-    if (artUri != null &&
-        artUri.scheme == 'file' &&
-        artUri.path.isNotEmpty &&
-        !artUri.path.contains('..') && // Prevent directory traversal
-        (artUri.path.endsWith('.jpg') ||
-            artUri.path.endsWith('.jpeg') ||
-            artUri.path.endsWith('.png') ||
-            artUri.path.endsWith('.bmp') ||
-            artUri.path.endsWith('.webp'))) {
+    try {
+      // Get metadata for the current track to access artBytes
+      final metadataService = _container!.read(metadataServiceProvider);
+      final metadata = await metadataService.getMetadata(mediaItem.id);
+
       final seedColorNotifier = _container!.read(seedColorProvider.notifier);
-      seedColorNotifier.updateFromAlbumArt(artUri.path);
-    } else {
-      // Reset to default color if no valid album art
+      seedColorNotifier.updateFromAlbumArtBytes(metadata.artBytes);
+    } catch (e) {
+      // If metadata retrieval fails, reset to default color
       final seedColorNotifier = _container!.read(seedColorProvider.notifier);
       seedColorNotifier.resetToDefault();
     }
diff --git a/lib/logic/metadata_service.dart b/lib/logic/metadata_service.dart
index 790d027..97a1c2f 100644
--- a/lib/logic/metadata_service.dart
+++ b/lib/logic/metadata_service.dart
@@ -1,7 +1,6 @@
 import 'dart:io';
 import 'dart:typed_data';
 import 'package:flutter_media_metadata/flutter_media_metadata.dart';
-import 'package:hooks_riverpod/hooks_riverpod.dart';
 import 'package:riverpod_annotation/riverpod_annotation.dart';
 
 part 'metadata_service.g.dart';
diff --git a/lib/providers/theme_provider.dart b/lib/providers/theme_provider.dart
index 7132ceb..a2bd9ef 100644
--- a/lib/providers/theme_provider.dart
+++ b/lib/providers/theme_provider.dart
@@ -1,4 +1,4 @@
-import 'dart:io';
+import 'dart:typed_data';
 
 import 'package:flutter/material.dart';
 import 'package:palette_generator/palette_generator.dart';
@@ -94,32 +94,16 @@ class SeedColorNotifier extends _$SeedColorNotifier {
     state = color;
   }
 
-  void updateFromAlbumArt(String? imagePath) async {
-    if (imagePath == null || imagePath.isEmpty) {
+  void updateFromAlbumArtBytes(Uint8List? artBytes) async {
+    if (artBytes == null || artBytes.isEmpty) {
       // Reset to default color if no album art
       state = defaultSeedColor;
       return;
     }
 
     try {
-      // Validate that the file exists before attempting to load it
-      final file = File(imagePath);
-      if (!await file.exists()) {
-        // File doesn't exist, reset to default color
-        state = defaultSeedColor;
-        return;
-      }
-
-      // Additional validation: check if file is readable and not empty
-      final fileStat = await file.stat();
-      if (fileStat.size == 0) {
-        // Empty file, reset to default color
-        state = defaultSeedColor;
-        return;
-      }
-
       final paletteGenerator = await PaletteGenerator.fromImageProvider(
-        FileImage(file),
+        MemoryImage(artBytes),
         size: const Size(200, 200),
         maximumColorCount: 20, // Increase color count for better extraction
       );
@@ -140,13 +124,21 @@ class SeedColorNotifier extends _$SeedColorNotifier {
       // Ensure we have a valid color, otherwise use default
       state = extractedColor ?? defaultSeedColor;
     } catch (e) {
-      // Log the error for debugging (in a real app, you'd use proper logging)
-      // debugPrint('Failed to extract color from album art: $e');
       // If color extraction fails, reset to default color
       state = defaultSeedColor;
     }
   }
 
+  // Keep the old method for backward compatibility, but mark as deprecated
+  @Deprecated(
+    'Use updateFromAlbumArtBytes instead. File path based color extraction is unreliable.',
+  )
+  void updateFromAlbumArt(String? imagePath) async {
+    // This method is deprecated, but kept for compatibility
+    // It will always reset to default since we now use artBytes
+    state = defaultSeedColor;
+  }
+
   void resetToDefault() {
     state = defaultSeedColor;
   }