From 1cce7c9b8111a3fa3a3ca4fd8cb9c11b17fbfe73 Mon Sep 17 00:00:00 2001
From: LittleSheep <littlesheep.code@hotmail.com>
Date: Sun, 18 Aug 2024 16:16:37 +0800
Subject: [PATCH] :bug: Fix schedule deletion will delete referenced file

---
 .idea/workspace.xml               | 8 ++++----
 pkg/internal/services/recycler.go | 5 ++++-
 2 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/.idea/workspace.xml b/.idea/workspace.xml
index 6a01e74..a51e4f2 100644
--- a/.idea/workspace.xml
+++ b/.idea/workspace.xml
@@ -4,10 +4,9 @@
     <option name="autoReloadType" value="ALL" />
   </component>
   <component name="ChangeListManager">
-    <list default="true" id="18dd0d68-b4b8-40db-9734-9119b5c848bd" name="更改" comment=":recycle: Split mark and delete file">
+    <list default="true" id="18dd0d68-b4b8-40db-9734-9119b5c848bd" name="更改" comment=":bug: Fix migration issue on pools">
       <change beforePath="$PROJECT_DIR$/.idea/workspace.xml" beforeDir="false" afterPath="$PROJECT_DIR$/.idea/workspace.xml" afterDir="false" />
-      <change beforePath="$PROJECT_DIR$/pkg/internal/database/migrator.go" beforeDir="false" afterPath="$PROJECT_DIR$/pkg/internal/database/migrator.go" afterDir="false" />
-      <change beforePath="$PROJECT_DIR$/pkg/internal/models/pools.go" beforeDir="false" afterPath="$PROJECT_DIR$/pkg/internal/models/pools.go" afterDir="false" />
+      <change beforePath="$PROJECT_DIR$/pkg/internal/services/recycler.go" beforeDir="false" afterPath="$PROJECT_DIR$/pkg/internal/services/recycler.go" afterDir="false" />
     </list>
     <option name="SHOW_DIALOG" value="false" />
     <option name="HIGHLIGHT_CONFLICTS" value="true" />
@@ -124,7 +123,8 @@
     <MESSAGE value=":sparkles: Attachment has pool" />
     <MESSAGE value=":sparkles: Pool clean by lifecycle config" />
     <MESSAGE value=":recycle: Split mark and delete file" />
-    <option name="LAST_COMMIT_MESSAGE" value=":recycle: Split mark and delete file" />
+    <MESSAGE value=":bug: Fix migration issue on pools" />
+    <option name="LAST_COMMIT_MESSAGE" value=":bug: Fix migration issue on pools" />
   </component>
   <component name="VgoProject">
     <settings-migrated>true</settings-migrated>
diff --git a/pkg/internal/services/recycler.go b/pkg/internal/services/recycler.go
index 683a66b..d6f08fe 100644
--- a/pkg/internal/services/recycler.go
+++ b/pkg/internal/services/recycler.go
@@ -51,7 +51,7 @@ func RunMarkDeletionTask() {
 	for _, pool := range pendingPools {
 		lifecycle := fmt.Sprintf("%d seconds", *pool.Config.Data().ExistLifecycle)
 		tx := database.C.
-			Where("pool_id = ? AND created_at < NOW() - INTERVAL ?", pool.ID, lifecycle).
+			Where("pool_id = ? AND  AND created_at < NOW() - INTERVAL ?", pool.ID, lifecycle).
 			Updates(&models.Attachment{CleanedAt: lo.ToPtr(time.Now())})
 		log.Info().
 			Str("pool", pool.Alias).
@@ -68,6 +68,9 @@ func RunScheduleDeletionTask() {
 	}
 
 	for idx, attachment := range attachments {
+		if attachment.RefID != nil {
+			continue
+		}
 		if err := DeleteFile(attachment); err != nil {
 			log.Error().
 				Uint("id", attachment.ID).