✨ Improve risk calculation

2024-01-29 18:38:19 +08:00 · 2024-01-29 18:38:19 +08:00 · f78ccd8d9d
commit f78ccd8d9d
parent 930607f0f2
1 changed files with 1 additions and 2 deletions
--- a/pkg/security/challanges.go
+++ b/pkg/security/challanges.go
@ -2,7 +2,6 @@ package security

 import (
 	"fmt"
-	"math"
 	"time"

 	"code.smartsheep.studio/hydrogen/passport/pkg/database"
@ -36,7 +35,7 @@ func NewChallenge(account models.Account, factors []models.AuthFactor, ip, ua st
 	}

 	// Thinking of the requirements factors
-	requirements := int(math.Max(float64(len(factors)), math.Min(float64(risk), 1)))
+	requirements := lo.Clamp(risk, 1, len(factors))

 	challenge = models.AuthChallenge{
 		IpAddress:        ip,