♻️ Still don't know what I am doing

DysonNetwork.Pusher/Notification/NotificationController.cs

@@ -1,15 +1,20 @@
 using System.ComponentModel.DataAnnotations;
+using DysonNetwork.Shared.Auth;
 using DysonNetwork.Shared.Proto;
 using Microsoft.AspNetCore.Authorization;
 using Microsoft.AspNetCore.Mvc;
 using Microsoft.EntityFrameworkCore;
 using NodaTime;
+using AccountService = DysonNetwork.Shared.Proto.AccountService;
 
 namespace DysonNetwork.Pusher.Notification;
 
 [ApiController]
 [Route("/api/notifications")]
-public class NotificationController(AppDatabase db, NotificationService nty) : ControllerBase
+public class NotificationController(
+    AppDatabase db,
+    PushService nty,
+    AccountService.AccountServiceClient accounts) : ControllerBase
 {
     [HttpGet("count")]
     [Authorize]
@@ -17,9 +22,10 @@ public class NotificationController(AppDatabase db, NotificationService nty) : C
     {
         HttpContext.Items.TryGetValue("CurrentUser", out var currentUserValue);
         if (currentUserValue is not Account currentUser) return Unauthorized();
+        var accountId = Guid.Parse(currentUser.Id);
 
         var count = await db.Notifications
-            .Where(s => s.AccountId == currentUser.Id && s.ViewedAt == null)
+            .Where(s => s.AccountId == accountId && s.ViewedAt == null)
             .CountAsync();
         return Ok(count);
     }
@@ -30,24 +36,25 @@ public class NotificationController(AppDatabase db, NotificationService nty) : C
         [FromQuery] int offset = 0,
         // The page size set to 5 is to avoid the client pulled the notification
         // but didn't render it in the screen-viewable region.
-        [FromQuery] int take = 5
+        [FromQuery] int take = 8
     )
     {
         HttpContext.Items.TryGetValue("CurrentUser", out var currentUserValue);
         if (currentUserValue is not Account currentUser) return Unauthorized();
+        var accountId = Guid.Parse(currentUser.Id);
 
         var totalCount = await db.Notifications
-            .Where(s => s.AccountId == currentUser.Id)
+            .Where(s => s.AccountId == accountId)
             .CountAsync();
         var notifications = await db.Notifications
-            .Where(s => s.AccountId == currentUser.Id)
+            .Where(s => s.AccountId == accountId)
             .OrderByDescending(e => e.CreatedAt)
             .Skip(offset)
             .Take(take)
             .ToListAsync();
 
         Response.Headers["X-Total"] = totalCount.ToString();
-        await nty.MarkNotificationsViewed(notifications);
+        await nty.MarkNotificationsViewed(notifications.ToList());
 
         return Ok(notifications);
     }
@@ -55,14 +62,15 @@ public class NotificationController(AppDatabase db, NotificationService nty) : C
     public class PushNotificationSubscribeRequest
     {
         [MaxLength(4096)] public string DeviceToken { get; set; } = null!;
-        public NotificationPushProvider Provider { get; set; }
+        public PushProvider Provider { get; set; }
     }
 
     [HttpPut("subscription")]
     [Authorize]
-    public async Task<ActionResult<NotificationPushSubscription>> SubscribeToPushNotification(
-        [FromBody] PushNotificationSubscribeRequest request
-    )
+    public async Task<ActionResult<PushSubscription>>
+        SubscribeToPushNotification(
+            [FromBody] PushNotificationSubscribeRequest request
+        )
     {
         HttpContext.Items.TryGetValue("CurrentSession", out var currentSessionValue);
         HttpContext.Items.TryGetValue("CurrentUser", out var currentUserValue);
@@ -72,8 +80,12 @@ public class NotificationController(AppDatabase db, NotificationService nty) : C
         if (currentSession == null) return Unauthorized();
 
         var result =
-            await nty.SubscribePushNotification(currentUser, request.Provider, currentSession.Challenge.DeviceId!,
-                request.DeviceToken);
+            await nty.SubscribeDevice(
+                currentSession.Challenge.DeviceId!,
+                request.DeviceToken,
+                request.Provider,
+                currentUser
+            );
 
         return Ok(result);
     }
@@ -88,10 +100,11 @@ public class NotificationController(AppDatabase db, NotificationService nty) : C
         if (currentUser == null) return Unauthorized();
         var currentSession = currentSessionValue as AuthSession;
         if (currentSession == null) return Unauthorized();
+        var accountId = Guid.Parse(currentUser.Id);
 
-        var affectedRows = await db.NotificationPushSubscriptions
+        var affectedRows = await db.PushSubscriptions
             .Where(s =>
-                s.AccountId == currentUser.Id &&
+                s.AccountId == accountId &&
                 s.DeviceId == currentSession.Challenge.DeviceId
             ).ExecuteDeleteAsync();
         return Ok(affectedRows);
@@ -107,36 +120,11 @@ public class NotificationController(AppDatabase db, NotificationService nty) : C
         public int Priority { get; set; } = 10;
     }
 
-    [HttpPost("broadcast")]
-    [Authorize]
-    [RequiredPermission("global", "notifications.broadcast")]
-    public async Task<ActionResult> BroadcastNotification(
-        [FromBody] NotificationRequest request,
-        [FromQuery] bool save = false
-    )
-    {
-        await nty.BroadcastNotification(
-            new Notification
-            {
-                CreatedAt = SystemClock.Instance.GetCurrentInstant(),
-                UpdatedAt = SystemClock.Instance.GetCurrentInstant(),
-                Topic = request.Topic,
-                Title = request.Title,
-                Subtitle = request.Subtitle,
-                Content = request.Content,
-                Meta = request.Meta,
-                Priority = request.Priority,
-            },
-            save
-        );
-        return Ok();
-    }
-
     public class NotificationWithAimRequest : NotificationRequest
     {
         [Required] public List<Guid> AccountId { get; set; } = null!;
     }
-    
+
     [HttpPost("send")]
     [Authorize]
     [RequiredPermission("global", "notifications.send")]
@@ -145,7 +133,6 @@ public class NotificationController(AppDatabase db, NotificationService nty) : C
         [FromQuery] bool save = false
     )
     {
-        var accounts = await db.Accounts.Where(a => request.AccountId.Contains(a.Id)).ToListAsync();
         await nty.SendNotificationBatch(
             new Notification
             {
@@ -157,7 +144,7 @@ public class NotificationController(AppDatabase db, NotificationService nty) : C
                 Content = request.Content,
                 Meta = request.Meta,
             },
-            accounts,
+            request.AccountId,
             save
         );
         return Ok();

DysonNetwork.Pusher/Notification/PushService.cs

@@ -12,14 +12,14 @@ public class PushService(IConfiguration config, AppDatabase db, IHttpClientFacto
     private readonly string _notifyTopic = config["Notifications:Topic"]!;
     private readonly Uri _notifyEndpoint = new(config["Notifications:Endpoint"]!);
 
-    public async Task UnsubscribePushNotifications(string deviceId)
+    public async Task UnsubscribeDevice(string deviceId)
     {
         await db.PushSubscriptions
             .Where(s => s.DeviceId == deviceId)
             .ExecuteDeleteAsync();
     }
 
-    public async Task<PushSubscription> SubscribePushNotification(
+    public async Task<PushSubscription> SubscribeDevice(
         string deviceId,
         string deviceToken,
         PushProvider provider,