🔊 Proper error handling in activitypub inbox

DysonNetwork.Sphere/ActivityPub/ActivityPubActivityHandler.cs

@@ -71,6 +71,8 @@ public class ActivityPubActivityHandler(
         logger.LogInformation("Signature verified successfully. Handling {Type} from {ActorUri}", 
             activityType, actorUri);
 
+        try
+        {
             switch (activityType)
             {
                 case "Follow":
@@ -97,6 +99,13 @@ public class ActivityPubActivityHandler(
                     return false;
             }
         }
+        catch (InvalidOperationException err)
+        {
+            logger.LogError("Failed to handle activity: {Type}, due to {Message}. Full activity: {Activity}",
+                activityType, err.Message, JsonSerializer.Serialize(activity));
+            return false;
+        }
+    }
 
     private async Task<bool> HandleFollowAsync(string actorUri, Dictionary<string, object> activity)
     {
@@ -252,8 +261,6 @@ public class ActivityPubActivityHandler(
     private async Task<bool> HandleUndoAsync(string actorUri, Dictionary<string, object> activity)
     {
         var objectValue = activity.GetValueOrDefault("object");
-        if (objectValue == null)
-            return false;
 
         if (objectValue is not Dictionary<string, object> objectDict) return false;
         var objectType = objectDict.GetValueOrDefault("type")?.ToString();
@@ -262,7 +269,7 @@ public class ActivityPubActivityHandler(
             "Follow" => await UndoFollowAsync(actorUri, objectDict.GetValueOrDefault("object")?.ToString()),
             "Like" => await UndoLikeAsync(actorUri, objectDict.GetValueOrDefault("object")?.ToString()),
             "Announce" => await UndoAnnounceAsync(actorUri, objectDict.GetValueOrDefault("object")?.ToString()),
-            _ => false
+            _ => throw new InvalidOperationException($"Unhandled undo operation for {objectType}")
         };
     }